User:Dforsi

Things to do (in random order)

• compiling 0.6.29git with cygwin has problems:
  • optind/optarg don't work as expected in gnokii (optind is always 1 and optarg is NULL)
  • gnokiid doesn't link because of unresolved symbols in libDATA
  • smsd can't find the file plugin
  • -fvisibility=hidden isn't supported but it only generates a warning so the configure check succeeds (add --fatal-warnings to configure check?)
• refactor common/gsm-mms.c to split PDU in chunks and store then in raw_mms and decode them only when copying to mms
• split common/phones/pcsc.c into a "phone" and a "links" file
• implement low level reading of SIM card on Sony Ericsson
• fix --getsmsc ignoring some errors when reading until "end" (need to add "end" keyword first?)
• [in progress in devel branch] check usage of *_MAX_LENGTH #defines, eg. this seems wrong:

./common/phones/nk6160.c:       char model[GN_MODEL_MAX_LENGTH + 1];
./common/phones/nk6510.c:       char model[10];
./common/phones/nk7110.c:       char model[10];
./common/phones/atgen.c:        char model[GN_MODEL_MAX_LENGTH];

• improve MNC reading with atgen driver to support :

AT+COPS?
+COPS: 0,0,"network name"

• [driver added by Pkot, need to add blacklist] add LG AT driver to blacklist all those commands that lock the phone (see LGU8120Config)
• [postponed] check usage of #include "compat.h": do not include outside of "compat.h" those files that can cause portability issues

Things done

• [done] check for non-option arguments where optional arguments are expected

	if (optind < argc) {
		/* There are arguments that don't start with '-' */
		divert_usage(stderr, -1);
	}

• [Pkot replaced them with snprintf()] check usage of strcpy() and strncpy() and think about replacing them with SAFE_STRNCPY from include/misc.h or with strlcpy [1] from OpenBSD
• [done by Pkot] increase cell id from 4 to 8 digits (to fix --getnetworkinfo for LGU8120Config e SagemmyW-8Config)
• [done by Pkot] add Sagem AT driver (see SagemmyW-8Config) because memory names need to be provided in the chosen encoding (this is alreadly done in atsoer.c, so perhaps Sagems can use this driver too, or the conversion can be turned into a more generic feature)
• Sagem replies "+CGMM: ..." (yes, CGMM) to "AT+GMM" command
• [done by hadess in this commit] replace hardcoded "bindir" in gnokiirc with a configure time or compile time value; fragment from the manual:

sbindir
   The directory for installing executable programs that can be run from the shell, but are only generally useful to system administrators.
This should normally be /usr/local/sbin, but write it as $(exec_prefix)/sbin. (If you are using Autoconf, write it as `@sbindir@'.)